fix: BigtableSession is never closed by Reader causing "ManagedChannel allocation site" exceptions (#2782)#2871
fix: BigtableSession is never closed by Reader causing "ManagedChannel allocation site" exceptions (#2782)#2871kolea2 wants to merge 1 commit into
Conversation
googleapis#2782) * fix: BigtableSession is never closed by Reader causing "ManagedChannel allocation site" exceptions * fix: BigtableSession is never closed by Reader causing "ManagedChannel allocation site" exceptions (cherry picked from commit 5340db5)
product-auto-label
Bot
added
the
api: bigtable
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
google-cla
Bot
added
the
cla: no
|
cherry pick of #2782 |
kolea2
added
cla: yes
| if (session != null) { | ||
| session.close(); | ||
| session = null; | ||
| } |
There was a problem hiding this comment.
I dont think we can do this due to channel pool caching
* Reader.close(): fixes googleapis#2658 where original fix googleapis#2782 was rolled back by googleapis#2871 and googleapis#2873. As we don’t use “session” here anymore, I believe we should close “connection” here. * AbstractCloudBigtableTableDoFn.tearDown(): If an exception happened in ProcessElement, FinishBundle is not executed. We should clean up resources in TearDown. You can see the similar code with BigQueryIO apache/beam#14949.
3 participants
fix: BigtableSession is never closed by Reader causing "ManagedChannel allocation site" exceptions
fix: BigtableSession is never closed by Reader causing "ManagedChannel allocation site" exceptions
(cherry picked from commit 5340db5)
Closes #2785